From: Joey Hess Date: Thu, 24 Jan 2019 17:05:44 GMT Subject: Re: git status OOM on mmap of large file Message-ID: <20190124170544.GB29200@kitenet.net> In-Reply-To: <20190124121427.GB4949@sigill.intra.peff.net> Jeff King wrote: > I didn't experiment with the smudge side, but I think it uses the same > apply_filter() code. Which means that yes, it would try to store the > 11GB in memory before writing it out. And I agree writing it out to a > file and moving it directly into place is the sanest option there. If > that doesn't work, spooling to a tempfile and then streaming it into > place would also work. I have seen that buffering on the smudge side, yes. In git-annex I happen to use the smudge filter in an unusual way that avoids that being a problem but I think it would affect git-lfs. -- see shy jo