From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Thu, 20 Dec 2018 00:21:38 GMT
Subject: Re: [PATCH 2/3] setup: do not use invalid `repository_format`
Message-ID: <20181220002137.GB35965@genre.crustytoothpaste.net>
In-Reply-To: <20181219153841.GB14802@sigill.intra.peff.net>

On Wed, Dec 19, 2018 at 10:38:41AM -0500, Jeff King wrote:
> Hmm. It looks like we never set repo_fmt.hash_algo to anything besides
> GIT_HASH_SHA1 anyway. I guess the existing field is really just there in
> preparation for us eventually respecting extensions.hashAlgorithm (or
> whatever it's called).

Yeah, it is.

I haven't tested, but since we just read the value of
extensions.objectFormat, this patch shouldn't have any effect on the
SHA-256 code. The default remains SHA-1 if a value isn't specified
somehow.
-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204