From: Jeff King Date: Sun, 11 Nov 2018 06:47:51 GMT Subject: Re: [PATCH 05/10] fast-export: move commit rewriting logic into a function for reuse Message-ID: <20181111064751.GE30850@sigill.intra.peff.net> In-Reply-To: <20181111062312.16342-6-newren@gmail.com> On Sat, Nov 10, 2018 at 10:23:07PM -0800, Elijah Newren wrote: > Logic to replace a filtered commit with an unfiltered ancestor is useful > elsewhere; put it into a function we can call. OK. I had to stare at it for a minute to make sure there was not an edge case with looking at "p" versus "p->parents", but I think it is a faithful conversion. -Peff