From: Jeff King Date: Sun, 11 Nov 2018 06:36:37 GMT Subject: Re: [PATCH 03/10] fast-export: use value from correct enum Message-ID: <20181111063636.GC30850@sigill.intra.peff.net> In-Reply-To: <20181111062312.16342-4-newren@gmail.com> On Sat, Nov 10, 2018 at 10:23:05PM -0800, Elijah Newren wrote: > ABORT and ERROR happen to have the same value, but come from differnt > enums. Use the one from the correct enum. Yikes. :) This is a good argument for naming these SIGNED_TAG_ABORT, etc. But this is obviously an improvement in the meantime. -Peff