From: SZEDER Gábor Date: Thu, 01 Nov 2018 15:48:57 GMT Subject: Re: [PATCH v5 6/7] revision.c: generation-based topo-order algorithm Message-ID: <20181101154857.GW30222@szeder.dev> In-Reply-To: <20181101134623.84055-7-dstolee@microsoft.com> On Thu, Nov 01, 2018 at 01:46:22PM +0000, Derrick Stolee wrote: > 1. EXPLORE: using the explore_queue priority queue (ordered by > maximizing the generation number) > 2. INDEGREE: using the indegree_queue priority queue (ordered > by maximizing the generation number) Nit: I've been pondering for a while what exactly does "order by maximizing ..." mean. Highest to lowest or lowest to highest? If I understand the rest of the descriptions (that I snipped) correctly, then it's the former, but I find that phrase in itself too ambiguous.