From: Denton Liu <liu.denton@gmail.com>
Date: Tue, 30 Oct 2018 03:50:36 GMT
Subject: Re: [PATCH] completion: use builtin completion for format-patch
Message-ID: <20181030035036.GA14941@archbookpro.localdomain>
In-Reply-To: <xmqqbm7c2n0i.fsf@gitster-ct.c.googlers.com>

On Tue, Oct 30, 2018 at 11:20:45AM +0900, Junio C Hamano wrote:
> We saw a similar change proposed and then found out it was not such
> a good idea in:
> 
> https://public-inbox.org/git/CACsJy8DUrVJu0HN7kuCeo4iV5aimWbYtr+E-7kenPVDx90DpGw@mail.gmail.com/
> 
> It seems that this one loses options like --full-index, --no-prefix,
> etc. compared to the earlier effort?

In _git_send_email, we have the following lines:

	__gitcomp "--annotate --bcc --cc --cc-cmd --chain-reply-to
		... more options ...
		$__git_format_patch_options"

Would it make sense to take the old `__git_format_patch_options` and
just roll them into here, then make `_git_format_patch` use
`__gitcomp_builtin format-patch`? That way, we'd be able to reap the
benefits of using `__gitcomp_builtin` where we can.