From: Jeff King <peff@peff.net>
Date: Sat, 27 Oct 2018 07:24:47 GMT
Subject: Re: [PATCH 00/10] Reduce #ifdef NO_PTHREADS
Message-ID: <20181027072447.GA26685@sigill.intra.peff.net>
In-Reply-To: <20181027071003.1347-1-pclouds@gmail.com>

On Sat, Oct 27, 2018 at 09:09:53AM +0200, Nguyễn Thái Ngọc Duy wrote:

> People seemed to support the idea of removing these #ifdef NO_PTHREADS [1]
> so this is a complete series. I left the #ifdef in run-command.c and
> transport-helper.c because those code looked complicated so perhaps we
> could clean them up later. Even these updated files could be updated
> more, I think, to reduce some code duplication, but I tried to keep
> the change here minimal.

Some of the bits in run-command.c can probably be converted, but all of
the "struct async" bits can't ever be. Because there the fallback is not
"OK, let's just run a single thread" but a whole separate forking
mechanism.

-Peff