From: brian m. carlson Date: Tue, 23 Oct 2018 00:43:41 GMT Subject: Re: [PATCH v3 10/12] Add a base implementation of SHA-256 support Message-ID: <20181023004340.GA6119@genre.crustytoothpaste.net> In-Reply-To: <20181022094440.GD30222@szeder.dev> On Mon, Oct 22, 2018 at 11:44:40AM +0200, SZEDER Gábor wrote: > To protect us from potential "macro redefinition" errors, these > #undefs should come before the #defines above. Note also that BLKSIZE > is not #undef-ed. Ah, okay. I think I misread your suggestion. I'll see if anyone has more comments, and then reroll with that change. -- brian m. carlson: Houston, Texas, US OpenPGP: https://keybase.io/bk2204