From: Jeff King <peff@peff.net>
Date: Mon, 22 Oct 2018 22:30:41 GMT
Subject: Re: [PATCH 1/1] archive: init archivers before determining format
Message-ID: <20181022223041.GA19019@sigill.intra.peff.net>
In-Reply-To: <20181022214756.GC233961@google.com>

On Mon, Oct 22, 2018 at 02:47:56PM -0700, Josh Steadmon wrote:

> > Does this work with configured archiver extensions, too? I think so,
> > because we load them via init_tar_archiver().
> 
> If you mean things like .tgz and .tar.gz, then yes, they are affected by
> the bug as well, and this patch fixes them. The test included in v2 uses
> a .tgz file.

Yes, but also ones that are provided by the user. E.g., does:

  git config tar.foo.command "foo"
  git archive -o out.tar.foo HEAD

work? (I think the answer is yes, because we read git_tar_config in the
same place).

-Peff