From: Jonathan Tan <jonathantanmy@google.com>
Date: Wed, 17 Oct 2018 21:26:24 GMT
Subject: Re: [PATCH 4/9] submodule.c: move global changed_submodule_names into fetch submodule struct
Message-ID: <20181017212624.196598-1-jonathantanmy@google.com>
In-Reply-To: <20181016181327.107186-5-sbeller@google.com>

> The `changed_submodule_names` are only used for fetching, so let's make it
> part of the struct that is passed around for fetching submodules.

Keep the titles of commit messages to 50 characters or under.

> +static void calculate_changed_submodule_paths(
> +	struct submodule_parallel_fetch *spf)

Instead of taking the entire struct, could this just take the list of
changed submodule names instead?