From: Jonathan Tan <jonathantanmy@google.com>
Date: Thu, 11 Oct 2018 22:01:47 GMT
Subject: Re: [PATCH 04/19] object-store: prepare read_object_file to deal with arbitrary repositories
Message-ID: <20181011220147.183266-1-jonathantanmy@google.com>
In-Reply-To: <20181011211754.31369-5-sbeller@google.com>

> Introduce repo_read_object_file which takes the repository argument, and
> hide the original read_object_file as a macro behind
> NO_THE_REPOSITORY_COMPATIBILITY_MACROS, which we planned for in
> e675765235 (diff.c: remove implicit dependency on the_index, 2018-09-21)

That commit didn't seem to plan for anything - it just seems to add a
new function with the name "repo_" preprended and define a macro if
NO_THE_REPOSITORY_COMPATIBILITY_MACROS is not set, just like this patch.
Maybe s/which we planned for in/just like in/.

The patch itself looks good.