From: Jeff King <peff@peff.net>
Date: Tue, 09 Oct 2018 21:06:20 GMT
Subject: Re: [PATCH 2/4] commit-graph: write a Bloom filter containing changed paths for each commit
Message-ID: <20181009210620.GA9563@sigill.intra.peff.net>
In-Reply-To: <20181009193445.21908-3-szeder.dev@gmail.com>

On Tue, Oct 09, 2018 at 09:34:43PM +0200, SZEDER Gábor wrote:

> Creating the Bloom filter is sloooow.  Running it on git.git takes
> about 23s on my hardware, while
> 
>   git log --format='%H%n%P' --name-only --all >/dev/null
> 
> gathers all the information necessary for that in about 5.3s.

That command won't open the trees for merges at all. But your
implementation here looks like it does a diff against each parent of a
merge. Adding "-m" would be a more accurate comparison, I think.

Though I find that puzzling, because "-m --name-only" seems to take
about 20x longer, not 3x. So perhaps I'm missing something.

-Peff