From: Phillip Wood Date: Thu, 04 Oct 2018 10:07:45 GMT Subject: [PATCH v2 5/5] diff --color-moved: fix a memory leak Message-ID: <20181004100745.4568-6-phillip.wood@talktalk.net> In-Reply-To: <20181004100745.4568-1-phillip.wood@talktalk.net> From: Phillip Wood Free the hashmap items as well as the hashmap itself. This was found with asan. Signed-off-by: Phillip Wood --- diff.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/diff.c b/diff.c index 69f6309db6..100d24b9c4 100644 --- a/diff.c +++ b/diff.c @@ -5768,8 +5768,8 @@ static void diff_flush_patch_all_file_pairs(struct diff_options *o) if (o->color_moved == COLOR_MOVED_ZEBRA_DIM) dim_moved_lines(o); - hashmap_free(&add_lines, 0); - hashmap_free(&del_lines, 0); + hashmap_free(&add_lines, 1); + hashmap_free(&del_lines, 1); } for (i = 0; i < esm.nr; i++) -- 2.19.0