From: Phillip Wood Date: Tue, 02 Oct 2018 17:55:14 GMT Subject: [PATCH 5/5] diff --color-moved: fix a memory leak Message-ID: <20181002175514.31495-5-phillip.wood@talktalk.net> In-Reply-To: <20181002175514.31495-1-phillip.wood@talktalk.net> From: Phillip Wood Free the hashmap items as well as the hashmap itself. This was found with asan. Signed-off-by: Phillip Wood --- diff.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/diff.c b/diff.c index 4464feacf8..94cc1b5592 100644 --- a/diff.c +++ b/diff.c @@ -5770,8 +5770,8 @@ static void diff_flush_patch_all_file_pairs(struct diff_options *o) if (o->color_moved == COLOR_MOVED_ZEBRA_DIM) dim_moved_lines(o); - hashmap_free(&add_lines, 0); - hashmap_free(&del_lines, 0); + hashmap_free(&add_lines, 1); + hashmap_free(&del_lines, 1); } for (i = 0; i < esm.nr; i++) -- 2.19.0