From: SZEDER Gábor <szeder.dev@gmail.com>
Date: Sat, 29 Sep 2018 00:51:28 GMT
Subject: Re: [PATCH v6 3/7] eoie: add End of Index Entry (EOIE) extension
Message-ID: <20180929005128.GD23446@localhost>
In-Reply-To: <20180926195442.1380-4-benpeart@microsoft.com>

On Wed, Sep 26, 2018 at 03:54:38PM -0400, Ben Peart wrote:
> diff --git a/read-cache.c b/read-cache.c
> index 6ba99e2c96..80255d3088 100644
> --- a/read-cache.c
> +++ b/read-cache.c

> +static size_t read_eoie_extension(const char *mmap, size_t mmap_size)
> +{

<....>

> +	the_hash_algo->final_fn(hash, &c);
> +	if (hashcmp(hash, (const unsigned char *)index))
> +		return 0;

Please use !hasheq() instead of hashcmp().