From: Taylor Blau <me@ttaylorr.com>
Date: Fri, 28 Sep 2018 02:37:24 GMT
Subject: Re: [PATCH] git help: promote 'git help -av'
Message-ID: <20180928023724.GA89283@syl>
In-Reply-To: <xmqq8t3omam8.fsf@gitster-ct.c.googlers.com>

On Wed, Sep 26, 2018 at 10:28:31AM -0700, Junio C Hamano wrote:
> Duy Nguyen <pclouds@gmail.com> writes:
>
> > Here's the patch that adds that external commands and aliases
> > sections. I feel that external commands section is definitely good to
> > have even if we don't replace "help -a". Aliases are more
> > subjective...
>
> I didn't apply this (so I didn't try running it), but a quick
> eyeballing tells me that the listing of external commands in -av
> output done in this patch seems reasonable.
>
> I do not think removing "-v" and making the current "help -a" output
> unavailable is a wise idea, though.

I think that your point about having to react in a split-second in order
to ^C before we open the manual page for a command is a good one. So, I
agree with this.

Thanks,
Taylor