From: Jonathan Tan <jonathantanmy@google.com>
Date: Thu, 27 Sep 2018 22:46:47 GMT
Subject: Re: [PATCH 0/2] negotiator: improve recent behavior + docs
Message-ID: <20180927224647.111690-1-jonathantanmy@google.com>
In-Reply-To: <87o9ciisg6.fsf@evledraar.gmail.com>

> I get:
> 
>     warning: Ignoring --negotiation-tip because the protocol does not support it.

When I implemented --negotiation-tip, I only implemented it for
protocols that support connect or stateless-connect, because
implementing it fully would have required expanding the protocol helper
functionality. For reference, the commit is 3390e42adb ("fetch-pack:
support negotiation tip whitelist", 2018-07-03).

So HTTPS wouldn't work unless you were using protocol v2.

> So that seems like another bug, and as an aside, a "skipping"
> implementation that sends ~1/4 of the commits in the repo seems way less
> aggressive than it should be. I was expecting something that would
> gradually "ramp up" from the tips. Where say starting at master/next/pu
> we present every 100th commit as a "have" until the 1000th commit, then
> every 1000 commits until 10k and quickly after that step up the size
> rapidly.

I reproduced using your commands, and yes, there is a bug - I'll take a
look.