From: Jeff King <peff@peff.net>
Date: Tue, 18 Sep 2018 17:16:43 GMT
Subject: Re: [PATCH] config doc: add missing list separator for checkout.optimizeNewBranch
Message-ID: <20180918171643.GC15470@sigill.intra.peff.net>
In-Reply-To: <20180918165707.GC72102@syl>

On Tue, Sep 18, 2018 at 12:57:07PM -0400, Taylor Blau wrote:

> Hi Ævar,
> 
> On Tue, Sep 18, 2018 at 05:34:49AM +0000, Ævar Arnfjörð Bjarmason wrote:
> > The documentation added in fa655d8411 ("checkout: optimize "git
> > checkout -b <new_branch>"", 2018-08-16) didn't add the double-colon
> > needed for the labeled list separator, as a result the added
> > documentation all got squashed into one paragraph. Fix that by adding
> > the list separator.
> 
> Looks good. Here's my:
> 
>   Signed-off-by: Taylor Blau <me@ttaylorr.com>

I'm confused here. The signoff is really about agreeing publicly to the
DCO, and providing a chain of custody for the changes. So sometimes a
signoff from somebody besides the patch author is good if they
contributed content to the patch, but I don't see that here (or in any
nearby thread).

Did you mean "Reviewed-by:" ?

-Peff