From: Jonathan Nieder Date: Sat, 08 Sep 2018 00:19:40 GMT Subject: Re: [PATCH v2] http-backend: allow empty CONTENT_LENGTH Message-ID: <20180908001940.GB225427@aiede.svl.corp.google.com> In-Reply-To: <20180907033607.24604-1-max@max630.net> Hi, Max Kirillov wrote: > According to RFC3875, empty environment variable is equivalent to unset, > and for CONTENT_LENGTH it should mean zero body to read. > > However, unset CONTENT_LENGTH is also used for chunked encoding to indicate > reading until EOF. At least, the test "large fetch-pack requests can be split > across POSTs" from t5551 starts faliing, if unset or empty CONTENT_LENGTH is > treated as zero length body. So keep the existing behavior as much as possible. > > Add a test for the case. > > Reported-By: Jelmer Vernooij > Signed-off-by: Max Kirillov > --- > Added the "reported-by" and explained inline the reason to keep existing behavior Lovely, thanks. To me, "keep the existing behavior as much as possible" isn't comforting because it doesn't tell me *which* existing behavior. Fortunately the patch itself is comforting: it makes us treat "" the same way as unset, which is exactly what the RFC requires. So I'm happy with this version. Thanks for your patient work. Reviewed-by: Jonathan Nieder