From: Jonathan Nieder <jrnieder@gmail.com>
Date: Wed, 05 Sep 2018 23:40:57 GMT
Subject: Re: [PATCH 1/2] submodule.c: convert submodule_move_head new argument to object id
Message-ID: <20180905234057.GF120842@aiede.svl.corp.google.com>
In-Reply-To: <20180905231952.28145-1-sbeller@google.com>

Stefan Beller wrote:

> Subject: submodule.c: convert submodule_move_head new argument to object id

Same nit as in https://public-inbox.org/git/20180905233203.GE120842@aiede.svl.corp.google.com/
applies about wondering which subsystem this is in.

[...]
> --- a/submodule.c
> +++ b/submodule.c
> @@ -1597,9 +1597,9 @@ static void submodule_reset_index(const char *path)
>   * pass NULL for old or new respectively.
>   */
>  int submodule_move_head(const char *path,
> -			 const char *old_head,
> -			 const char *new_head,
> -			 unsigned flags)
> +			const char *old_head,
> +			const struct object_id *new_oid,
> +			unsigned flags)

This seems oddly asymmetrical.  Should the old value be passed as an
object_id as well?

Curious,
Jonathan