From: Jonathan Nieder <jrnieder@gmail.com>
Date: Wed, 15 Aug 2018 05:28:07 GMT
Subject: Re: [PATCHv3 5/6] compat/precompose_utf8.h: use more common include guard style
Message-ID: <20180815052807.GG32543@aiede.svl.corp.google.com>
In-Reply-To: <20180813171749.10481-6-newren@gmail.com>

Elijah Newren wrote:

> Signed-off-by: Elijah Newren <newren@gmail.com>
> ---
>  compat/precompose_utf8.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

The more unusual style is less likely to be recognized by compilers, so
we can waste some I/O re-reading the header at compile time.

> --- a/compat/precompose_utf8.h
> +++ b/compat/precompose_utf8.h
> @@ -1,4 +1,6 @@
>  #ifndef PRECOMPOSE_UNICODE_H
> +#define PRECOMPOSE_UNICODE_H
> +
>  #include <sys/stat.h>
>  #include <sys/types.h>
>  #include <dirent.h>

Not about this patch: these headers are #include-d in git-compat-util.h
which we assume to be already included first before anything else.  Can
we remove these redundant #includes?