From: Jonathan Nieder Date: Mon, 30 Jul 2018 21:04:38 GMT Subject: Re: [PATCH] mw-to-git/t9360: fix broken &&-chain Message-ID: <20180730210438.GF156463@aiede.svl.corp.google.com> In-Reply-To: <20180730204646.32312-1-sunshine@sunshineco.com> (+cc: some folks interested in git-remote-mediawiki) Hi, Eric Sunshine wrote: > Signed-off-by: Eric Sunshine > --- > Jonathan's discovery[1] of a broken &&-chain in a contrib/subtree test > prompted me to check other tests bundled in contrib/. This was the > only other problem found. Unlike the subtree &&-chain case, this > breakage is at the top-level, thus was caught by the normal > --chain-lint mechanism, not the subshell linter. > > [1]: https://public-inbox.org/git/20180730190612.GB156463@aiede.svl.corp.google. > com/ A small detail from there would be useful to have in the commit message: namely that this was detected using --chain-lint (and what command I can run to reproduce it myself). With or without such a tweak to the commit message, Reviewed-by: Jonathan Nieder Thanks. > contrib/mw-to-git/t/t9360-mw-to-git-clone.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/contrib/mw-to-git/t/t9360-mw-to-git-clone.sh b/contrib/mw-to-git/t/t9360-mw-to-git-clone.sh > index 22f069db48..cfbfe7ddf6 100755 > --- a/contrib/mw-to-git/t/t9360-mw-to-git-clone.sh > +++ b/contrib/mw-to-git/t/t9360-mw-to-git-clone.sh > @@ -247,7 +247,7 @@ test_expect_success 'Test of resistance to modification of category on wiki for > wiki_editpage Notconsidered "this page will not appear on local" false && > wiki_editpage Othercategory "this page will not appear on local" false -c=Cattwo && > wiki_editpage Tobeedited "this page have been modified" true -c=Catone && > - wiki_delete_page Tobedeleted > + wiki_delete_page Tobedeleted && > git clone -c remote.origin.categories="Catone" \ > mediawiki::'"$WIKI_URL"' mw_dir_14 && > wiki_getallpage ref_page_14 Catone && > -- > 2.18.0.597.ga71716f1ad >