From: Jeff King <peff@peff.net>
Date: Fri, 27 Jul 2018 11:29:50 GMT
Subject: Re: [RFC PATCH 1/5] packfile: make get_delta_base() non static
Message-ID: <20180727112950.GA18599@sigill.intra.peff.net>
In-Reply-To: <xmqqy3e0zjw0.fsf@gitster-ct.c.googlers.com>

On Tue, Jul 24, 2018 at 09:19:27AM -0700, Junio C Hamano wrote:

> Christian Couder <christian.couder@gmail.com> writes:
> 
> > From: Jeff King <peff@peff.net>
> >
> > As get_delta_base() will be used outside 'packfile.c' in
> > a following commit, let's make it non static and let's
> > declare it in 'packfile.h'.
> 
> As a public function in *.h, don't we want a bit of comment there to
> help those who want to use it from outside packfile.c?

Arguably it may want a better name, too.

-Peff