From: Jonathan Nieder <jrnieder@gmail.com>
Date: Mon, 23 Jul 2018 17:41:08 GMT
Subject: Re: [PATCH 2/9] vscode: hard-code a couple defines
Message-ID: <20180723174108.GA9285@aiede.svl.corp.google.com>
In-Reply-To: <3770bd855c6f3e69acfe418ea7fe5b40454e4dfb.1532353966.git.gitgitgadget@gmail.com>

Hi,

Johannes Schindelin via GitGitGadget wrote:

> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> Sadly, we do not get all of the definitions via ALL_CFLAGS. Some defines
> are passed to GCC *only* when compiling specific files, such as git.o.
>
> Let's just hard-code them into the script for the time being.

Could we move these to ALL_CFLAGS?  Is there any downside other than
increased rebuilds when options change?

Thanks,
Jonathan