From: Jonathan Tan <jonathantanmy@google.com>
Date: Mon, 16 Jul 2018 22:37:03 GMT
Subject: Re: [PATCH 07/16] commit-reach: move can_all_from_reach_with_flags
Message-ID: <20180716223703.252965-1-jonathantanmy@google.com>
In-Reply-To: <cf4559e08c47adcaf4c938a325acf829a5759285.1531746011.git.gitgitgadget@gmail.com>

>  /* Remember to update object flag allocation in object.h */
> +#define REACHABLE       (1u<<15)
>  #define PARENT1		(1u<<16)
>  #define PARENT2		(1u<<17)
>  #define STALE		(1u<<18)

Update the object flag allocation in object.h.

> +int reachable(struct commit *from, int with_flag, int assign_flag,
> +	      time_t min_commit_date)

In this and previous patches: I think it's better to use "unsigned int"
as the data type for a flag, just like in clear_commit_marks().

Other than that, this and all previous patches look good.