From: Jeff King Date: Mon, 16 Jul 2018 21:12:35 GMT Subject: Re: [PATCH] gc: do not warn about too many loose objects Message-ID: <20180716211234.GG25189@sigill.intra.peff.net> In-Reply-To: <20180716205646.GF11513@aiede.svl.corp.google.com> On Mon, Jul 16, 2018 at 01:56:46PM -0700, Jonathan Nieder wrote: > I don't believe we are very good at transitively propagating freshness > today, by the way. Perhaps I don't understand what you mean by transitive here. But we should be traversing from any fresh object and marking any non-fresh ones that are reachable from it to be saved. If you know of a case where we're not, there's a bug, and I'd be happy to look into it. The only problem I know about is the utter lack of atomicity. -Peff