From: Taylor Blau <me@ttaylorr.com>
Date: Mon, 16 Jul 2018 15:21:52 GMT
Subject: Re: [PATCH v2 00/16] object_id part 14
Message-ID: <20180716152152.GA51419@syl.attlocal.net>
In-Reply-To: <20180716012808.961328-1-sandals@crustytoothpaste.net>

On Mon, Jul 16, 2018 at 01:27:52AM +0000, brian m. carlson wrote:
> This is the fourteenth series of patches to switch to using struct
> object_id and the_hash_algo.  This series converts several core pieces
> to use struct object_id, including the oid* and hex functions.
>
> All of these patches have been tested with both SHA-1 and a 256-bit
> hash.
>
> Most of these patches are fixes for things that will clearly cause
> segfaults or other very obvious breakage on a Git with a 256-bit hash.
>
> Changes from v1:
> * Drop patch that's been replaced by one from Ben Peart.
> * Update patch handling hash* and oid* functions.

Along with Derrick, I also read this series and found it to be without
problems. This looks good to me, too.

Reviewed-by: Taylor Blau <me@ttaylorr.com>

Thanks,
Taylor