From: Jeff King <peff@peff.net>
Date: Thu, 12 Jul 2018 15:56:03 GMT
Subject: Re: [PATCH v3 1/3] t5541: clean up truncating access log
Message-ID: <20180712155602.GA8889@sigill.intra.peff.net>
In-Reply-To: <20180712122216.12691-2-szeder.dev@gmail.com>

On Thu, Jul 12, 2018 at 02:22:14PM +0200, SZEDER Gábor wrote:

> diff --git a/t/t5541-http-push-smart.sh b/t/t5541-http-push-smart.sh
> index a2af693068..5c9ca19401 100755
> --- a/t/t5541-http-push-smart.sh
> +++ b/t/t5541-http-push-smart.sh
> @@ -38,6 +38,10 @@ GET  /smart/test_repo.git/info/refs?service=git-upload-pack HTTP/1.1 200
>  POST /smart/test_repo.git/git-upload-pack HTTP/1.1 200
>  EOF
>  test_expect_success 'no empty path components' '
> +	# Clear the log, so that it does not affect the "used receive-pack
> +	# service" test which reads the log too.
> +	test_when_finished ">\"$HTTPD_ROOT_PATH\"/access.log" &&

I think you want to escape the $ here, too, so the eval sees the
variable and not its expanded value.

Other than that, this iteration looks good (and patch 3 is much easier
to read).

-Peff