From: Jeff King <peff@peff.net>
Date: Wed, 11 Jul 2018 17:35:13 GMT
Subject: Re: [PATCH v2 3/3] t/lib-httpd: avoid occasional failures when checking access.log
Message-ID: <20180711173513.GA24949@sigill.intra.peff.net>
In-Reply-To: <CAM0VKjm8V58w=2+Zx+ykrfmOmNDOtPY5HeuFy+mWm_H40UrF1A@mail.gmail.com>

On Wed, Jul 11, 2018 at 07:26:19PM +0200, SZEDER Gábor wrote:

> > But it is really "make sure that a failed test here does not prevent us
> > from doing this cleanup". So the original really should have just
> > dropped that comment and added a test_when_finished. Bumping it into a
> > separate test as you have here accomplishes the same thing.
> 
> After taking a step back, I think this would fit better into the first
> patch, wouldn't it?
> I will send v3 shortly.

Yeah, I agree it would be even nicer to clean it up there.

-Peff