From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Fri, 06 Jul 2018 20:18:43 GMT
Subject: Re: [PATCH 2/3] send-email: accept long lines with suitable transfer encoding
Message-ID: <20180706201843.GF7697@genre.crustytoothpaste.net>
In-Reply-To: <20180706122604.GA9255@homura.localdomain>

On Fri, Jul 06, 2018 at 08:26:04AM -0400, Drew DeVault wrote:
> On 2018-07-06  2:23 AM, brian m. carlson wrote:
> > diff --git a/git-send-email.perl b/git-send-email.perl
> > index a76953c310..4ea30c4070 100755
> > --- a/git-send-email.perl
> > +++ b/git-send-email.perl
> > @@ -1899,6 +1899,10 @@ sub validate_patch {
> >  		return $hook_error if $hook_error;
> >  	}
> >  
> > +	# Any long lines will be automatically fixed if we use a suitable transfer
> > +	# encoding.
> > +	return if $xfer_encoding =~ /^(?:auto|quoted-printable|base64)$/;
> 
> Rather than returning in this case I'd sooner wrap the length check in
> this test. If additional checks are added in the future it'd be too easy
> to accidentally skip them if the transfer encoding is quoted-printable.

Okay, that's fair.  I can do that.
-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204