From: Henning Schild Date: Fri, 06 Jul 2018 08:01:48 GMT Subject: Re: [PATCH 0/8] X509 (gpgsm) commit signing support Message-ID: <20180706100148.7b878808@md1pvb1c.ad001.siemens.net> In-Reply-To: <20180706011834.GD7697@genre.crustytoothpaste.net> Am Fri, 6 Jul 2018 01:18:35 +0000 schrieb "brian m. carlson" : > On Tue, Jul 03, 2018 at 02:38:12PM +0200, Henning Schild wrote: > > This series adds support for signing commits with gpgsm. > > > > The first two patches are cleanups of gpg-interface, while the next > > four prepare for the introduction of the actual feature in patch 7. > > Finally patch 8 extends the testsuite to cover the new feature. > > > > This series can be seen as a follow up of a series that appeared > > under the name "gpg-interface: Multiple signing tools" in april > > 2018 [1]. After that series was not merged i decided to get my > > patches ready. The original series aimed at being generic for any > > sort of signing tool, while this series just introduced the X509 > > variant of gpg. (gpgsm) I collected authors and reviewers of that > > first series and already put them on cc. > > Overall, I think this is heading in a good direction. I left a few > comments, but it seemed pretty sane. Thanks, i hope others think so too and that will eventually get merged. Henning