From: Jonathan Tan <jonathantanmy@google.com>
Date: Mon, 25 Jun 2018 18:09:34 GMT
Subject: Re: [PATCH v3 2/8] upload-pack: implement ref-in-want
Message-ID: <20180625180934.229573-1-jonathantanmy@google.com>
In-Reply-To: <20180620213235.10952-3-bmwill@google.com>

> +static int parse_want_ref(const char *line, struct string_list *wanted_refs)
> +{
> +	const char *arg;
> +	if (skip_prefix(line, "want-ref ", &arg)) {
> +		struct object_id oid;
> +		struct string_list_item *item;
> +		struct object *o;
> +
> +		if (read_ref(arg, &oid))
> +			die("unknown ref %s", arg);

One more thing - if you're planning to "die" here, also write out an
error to the user, just like in parse_want().