From: Taylor Blau <me@ttaylorr.com>
Date: Tue, 19 Jun 2018 17:02:48 GMT
Subject: Re: [PATCH 2/7] grep.c: expose {,inverted} match column in match_line()
Message-ID: <20180619170248.GA37277@syl.attlocal.net>
In-Reply-To: <xmqqwouuvi0e.fsf@gitster-ct.c.googlers.com>

On Tue, Jun 19, 2018 at 09:49:21AM -0700, Junio C Hamano wrote:
> Taylor Blau <me@ttaylorr.com> writes:
>
> >  	case GREP_NODE_NOT:
> > -		h = !match_expr_eval(x->u.unary, bol, eol, ctx, 0);
> > +		/*
> > +		 * Upon visiting a GREP_NODE_NOT, imatch and match become
> > +		 * swapped.
> > +		 */
> > +		h = !match_expr_eval(x->u.unary, bol, eol, ctx, icol, col, 0);
>
> A minor nit, but the comment talks about something that are
> different from the variable names; perhaps you called col/icol with
> different names in an earlier incarnation of this patch?

Good catch, thanks. I've amended my local copy.

Thanks,
Taylor