From: Jeff King Date: Thu, 14 Jun 2018 17:56:51 GMT Subject: Re: [RFC PATCH 0/4] Fix occasional test failures in http tests Message-ID: <20180614175650.GA15544@sigill.intra.peff.net> In-Reply-To: <20180614123107.11608-1-szeder.dev@gmail.com> On Thu, Jun 14, 2018 at 02:31:03PM +0200, SZEDER Gábor wrote: > 't5561-http-backend.sh' is prone to occasional failures; luckily it's > not 'git-http-backend's fault, but the test script is a bit racy. I > won't go into the details here, patch 4/4's commit message discusses > it at length. 4/4 also fixes this issue, but I'm not particularly > happy with that fix, the note attached to that patch explains why, > along with possible alternatives, hence the RFC. > > Even if we settle for a different fix, I think the first two patches > are worthy cleanups on their own right. Yes, the first two look like improvements on their own (and I left more detailed comments on the final one). Thanks for tackling this! -Peff