From: Jeff King Date: Sat, 09 Jun 2018 09:31:18 GMT Subject: [PATCH v2 1/2] t7415: don't bother creating commit for symlink test Message-ID: <20180609093118.GA8942@sigill.intra.peff.net> In-Reply-To: <20180609093028.GA8864@sigill.intra.peff.net> Early versions of the fsck .gitmodules detection code actually required a tree to be at the root of a commit for it to be checked for .gitmodules. What we ended up with in 159e7b080b (fsck: detect gitmodules files, 2018-05-02), though, finds a .gitmodules file in _any_ tree (see that commit for more discussion). As a result, there's no need to create a commit in our tests. Let's drop it in the name of simplicity. Signed-off-by: Jeff King --- t/t7415-submodule-names.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/t/t7415-submodule-names.sh b/t/t7415-submodule-names.sh index a770d92a55..e2aae587ae 100755 --- a/t/t7415-submodule-names.sh +++ b/t/t7415-submodule-names.sh @@ -141,7 +141,6 @@ test_expect_success 'fsck detects symlinked .gitmodules file' ' printf "120000 blob $target\t.gitmodules\n" } | git mktree ) && - commit=$(git commit-tree $tree) && # Check not only that we fail, but that it is due to the # symlink detector; this grep string comes from the config -- 2.18.0.rc1.446.g4486251e51