From: Jonathan Tan Date: Thu, 17 May 2018 22:53:13 GMT Subject: Re: [PATCH 0/8] Reroll of sb/diff-color-move-more Message-ID: <20180517155313.6a529d76ab1f6e8f2a05e1a8@google.com> In-Reply-To: <20180517194653.48928-1-sbeller@google.com> On Thu, 17 May 2018 12:46:45 -0700 Stefan Beller wrote: > Stefan Beller (8): > xdiff/xdiff.h: remove unused flags > xdiff/xdiffi.c: remove unneeded function declarations > diff.c: do not pass diff options as keydata to hashmap > diff.c: adjust hash function signature to match hashmap expectation > diff.c: add a blocks mode for moved code detection > diff.c: decouple white space treatment from move detection algorithm > diff.c: add --color-moved-ignore-space-delta option > diff: color-moved white space handling options imply color-moved The test in patch 7 is indeed fixed, and patch 8 looks good to me. There are still some review comments of mine outstanding [1] [2] but if we decide that this series is good enough for now, that's OK. [1] https://public-inbox.org/git/20180424153513.dc2404cd111c44ac78bd8ed8@google.com/ [2] https://public-inbox.org/git/20180424171123.7092788b94498908c25eccf0@google.com/