From: Jeff King <peff@peff.net>
Date: Mon, 14 May 2018 14:09:00 GMT
Subject: Re: [PATCH 4/4] mark_parents_uninteresting(): avoid most allocation
Message-ID: <20180514140900.GA10636@sigill.intra.peff.net>
In-Reply-To: <bacb6ac4-637d-43c8-8789-2a345097d42a@gmail.com>

On Mon, May 14, 2018 at 09:25:46AM -0400, Derrick Stolee wrote:

> > I think you'd want to go the other way: this is marking uninteresting
> > commits, so you'd want origin/master..master, which would make those 70k
> > commits uninteresting.
> 
> Thanks for the tip. Running 'git rev-list origin/master..master' 100 times
> gave the following times, on average (with ds/generation-numbers):
> 
> PATCH 3/4: 0.19 s
> PATCH 4/4: 0.16 s
>     Rel %: -16%

Nifty. I liked it as just a cleanup, but I'm happier still to find that
it makes things faster (even if it's pretty small in absolute numbers).

-Peff