From: Jonathan Tan <jonathantanmy@google.com>
Date: Wed, 09 May 2018 17:13:30 GMT
Subject: Re: [PATCHv2 0/4] Rebooting pc/submodule-helper-foreach
Message-ID: <20180509101330.f41a1d9c03f6af759398137b@google.com>
In-Reply-To: <20180509002952.172347-1-sbeller@google.com>

On Tue,  8 May 2018 17:29:48 -0700
Stefan Beller <sbeller@google.com> wrote:

> v2:
> * rebased onto origin/master
> * dropped leftover "toplevel" variable from experimentation
> * reworded the commit message for the first patch extensively
> * dropped the third patch
> * see "branch-diff" below.

Patches 1-3 look good to me.

I also can't see anything wrong with patch 4, but I am not an expert at
shell and how we call it from C, so a review from another reviewer would
be appreciated.