From: Jonathan Tan <jonathantanmy@google.com>
Date: Thu, 03 May 2018 23:45:09 GMT
Subject: Re: [PATCH v2 2/3] upload-pack: read config when serving protocol v2
Message-ID: <20180503164509.83dd9c113ddb849584863c08@google.com>
In-Reply-To: <CAGZ79kb4gHO=5aYMbT=AhZrOexkmkRakJRPRZd_GMrQJTF3WwQ@mail.gmail.com>

On Thu, 3 May 2018 12:08:16 -0700
Stefan Beller <sbeller@google.com> wrote:

> test_path_is_missing ?

Thanks for the pointer. Done.

> > +       GIT_TRACE=/tmp/y git -c protocol.version=2 clone "file://$(pwd)/server" client &&
> 
> Why do we redirect GIT_TRACE outside the test suite? do we read that
> back or want to read it out of the hook?
> 
> Is it possible to redirect to  /$(pwd)/trace or such?

Good catch - that was a leftover from debugging. I've just removed it.

> > +       test -f server/.git/hookout
> 
> test_path_is_file ?

Done.