From: Jonathan Tan <jonathantanmy@google.com>
Date: Thu, 03 May 2018 18:05:00 GMT
Subject: Re: [PATCH 5/5] submodule: port submodule subcommand 'foreach' from shell to C
Message-ID: <20180503110500.cbabf44370b28302d74d9701@google.com>
In-Reply-To: <20180503005358.89082-6-sbeller@google.com>

On Wed,  2 May 2018 17:53:58 -0700
Stefan Beller <sbeller@google.com> wrote:

> +		argv_array_pushf(&cp.args, "path=%s; %s",
> +				path, info->argv[0]);

Do we need to quote the path here? (For example, what if path has a
quotation mark?)

Also, would it be useful to have a test testing a submodule with a
"weird" character (e.g. greater-than or single quote) in the name and
the path?