From: Duy Nguyen Date: Tue, 01 May 2018 10:01:14 GMT Subject: Re: [PATCH 04/41] packfile: remove unused member from struct pack_entry Message-ID: <20180501100114.GD15820@duynguyen.home> In-Reply-To: <20180423233951.276447-5-sandals@crustytoothpaste.net> On Mon, Apr 23, 2018 at 11:39:14PM +0000, brian m. carlson wrote: > The sha1 member in struct pack_entry is unused except for one instance > in which we store a value in it. Since nobody ever reads this value, > don't bother to compute it and remove the member from struct pack_entry. Never used since its introduction in 1f688557c0 ([PATCH] Teach read_sha1_file() and friends about packed git object store. - 2005-06-27). Good riddance. -- Duy