From: Duy Nguyen Date: Tue, 01 May 2018 09:50:04 GMT Subject: Re: [PATCH 03/41] Remove unused member in struct object_context Message-ID: <20180501095004.GC15820@duynguyen.home> In-Reply-To: <20180423233951.276447-4-sandals@crustytoothpaste.net> On Mon, Apr 23, 2018 at 11:39:13PM +0000, brian m. carlson wrote: > The tree member of struct object_context is unused except in one place > where we write to it. Since there are no users of this member, remove > it. Yep. It's never used since its introduction in 573285e552 (sha1_name: add get_sha1_with_context() - 2010-06-09) in 'cp/textconv-cat-file' topic. I guess the idea at that time was to keep all the information from get_tree_entry() in object context for future use. Since it's been eight years and nobody needs it still, it should be good to go. -- Duy