From: Jonathan Tan <jonathantanmy@google.com>
Date: Thu, 26 Apr 2018 23:23:39 GMT
Subject: Re: [PATCH v3 1/3] merge: update documentation for {merge,diff}.renameLimit
Message-ID: <20180426162339.db6b4855fedb5e5244ba7dd1@google.com>
In-Reply-To: <CABPp-BEa2EDdeDfcXxRERKAuOPUYTsBGZB8XyTXDYN1JpHsbXA@mail.gmail.com>

On Thu, 26 Apr 2018 16:11:50 -0700
Elijah Newren <newren@gmail.com> wrote:

> Patch looks fine, but it's hard for me not to notice a separate issue
> in this area independent of your series: I'm curious if we should
> document that the value of 0 is special here (as per Jonathan Tan's
> commit 89973554b52c ("diffcore-rename: make diff-tree -l0 mean
> -l<large>", 2017-11-29)), and doesn't actually drop the limit to 0.
> cc'ing Jonathan Tan for his thoughts.

Documenting that the value of 0 is special does make sense to me. I
think this patch can go in as-is, though - it is already an improvement.