From: brian m. carlson Date: Tue, 24 Apr 2018 00:34:15 GMT Subject: Re: [PATCH 9/9] cache.h: allow sha1_object_info to handle arbitrary repositories Message-ID: <20180424003414.GB245996@genre.crustytoothpaste.net> In-Reply-To: <20180423234327.250484-10-sbeller@google.com> On Mon, Apr 23, 2018 at 04:43:27PM -0700, Stefan Beller wrote: > This involves also adapting sha1_object_info_extended and a some > internal functions that are used to implement these. It all has to > happen in one patch, because of a single recursive chain of calls visits > all these functions. Ah, yes, I remember that recursive call chain. Anyway, other than the one item I mentioned earlier, this series looked good to me. -- brian m. carlson: Houston, Texas, US OpenPGP: https://keybase.io/bk2204