From: brian m. carlson Date: Mon, 23 Apr 2018 23:39:14 GMT Subject: [PATCH 04/41] packfile: remove unused member from struct pack_entry Message-ID: <20180423233951.276447-5-sandals@crustytoothpaste.net> In-Reply-To: <20180423233951.276447-1-sandals@crustytoothpaste.net> The sha1 member in struct pack_entry is unused except for one instance in which we store a value in it. Since nobody ever reads this value, don't bother to compute it and remove the member from struct pack_entry. Signed-off-by: brian m. carlson --- cache.h | 1 - packfile.c | 1 - 2 files changed, 2 deletions(-) diff --git a/cache.h b/cache.h index 11a989319d..dd1a9c6094 100644 --- a/cache.h +++ b/cache.h @@ -1572,7 +1572,6 @@ struct pack_window { struct pack_entry { off_t offset; - unsigned char sha1[20]; struct packed_git *p; }; diff --git a/packfile.c b/packfile.c index 0bc67d0e00..5c219d0229 100644 --- a/packfile.c +++ b/packfile.c @@ -1833,7 +1833,6 @@ static int fill_pack_entry(const unsigned char *sha1, return 0; e->offset = offset; e->p = p; - hashcpy(e->sha1, sha1); return 1; }