From: Jeff King <peff@peff.net>
Date: Fri, 06 Apr 2018 21:23:51 GMT
Subject: Re: [PATCH v2 09/15] config: avoid using the global variable `store`
Message-ID: <20180406212351.GB7870@sigill.intra.peff.net>
In-Reply-To: <a9689c880f9226c236aec58f8036740ff39efbb8.1522772789.git.johannes.schindelin@gmx.de>

On Tue, Apr 03, 2018 at 06:28:34PM +0200, Johannes Schindelin wrote:

> It is much easier to reason about, when the config code to set/unset
> variables or to remove/rename sections does not rely on a global (or
> file-local) variable.

Agreed.

> -static struct {
> +struct config_set_store {

This made me think of the existing "configset", which is quite a
different thing. Maybe just "config_store_data" or something would clash
less.

-Peff