From: Jeff King Date: Thu, 05 Apr 2018 22:12:02 GMT Subject: Re: [PATCH v4 2/2] builtin/config.c: prefer `--type=bool` over `--bool`, etc. Message-ID: <20180405221201.GA29929@sigill.intra.peff.net> In-Reply-To: <20180405020238.GD8879@syl.local> On Wed, Apr 04, 2018 at 07:02:38PM -0700, Taylor Blau wrote: > +test_expect_success '--no-type unsets type specifiers' ' > + echo "10" > expect && > + git config --type=bool --no-type core.number >actual && > + test_cmp expect actual > +' Actually, one minor nit (not worth a re-roll, but Junio may want to mark it up): drop the space in "> expect". -Peff