From: Jeff King <peff@peff.net>
Date: Tue, 03 Apr 2018 23:19:03 GMT
Subject: Re: [PATCH 2/6] commit: add generation number to struct commmit
Message-ID: <20180403231903.GA9107@sigill.intra.peff.net>
In-Reply-To: <08d3c9dd-3589-5c1c-4cea-982e8ed28f3e@ramsayjones.plus.com>

On Wed, Apr 04, 2018 at 12:17:06AM +0100, Ramsay Jones wrote:

> >> Is there any reason to believe this would be too small of a value in the
> >> future?  Or is a 32 bit unsigned good enough?
> > 
> > The linux kernel took ~10 years to produce 500k commits. Even assuming
> > those were all linear (and they're not), that gives us ~80,000 years of
> > leeway. So even if the pace of development speeds up or we have a
> > quicker project, it still seems we have a pretty reasonable safety
> > margin.
> 
> I didn't read the patches closely, but isn't it ~20,000 years?
> 
> Given that '#define GENERATION_NUMBER_MAX 0x3FFFFFFF', that is. ;-)

What, I'm supposed to read the patches before responding? Heresy.

-Peff