From: Thomas Gummerer <t.gummerer@gmail.com>
Date: Mon, 02 Apr 2018 22:09:52 GMT
Subject: Re: [PATCH v6 2/6] reset: introduce show-new-head-line option
Message-ID: <20180402220952.GH2629@hank>
In-Reply-To: <xmqqsh8dxs86.fsf@gitster-ct.c.googlers.com>

On 04/02, Junio C Hamano wrote:
> Thomas Gummerer <t.gummerer@gmail.com> writes:
> 
> > +test_expect_success 'reset --no-show-new-head-line suppresses "HEAD is now at" output' '
> > +	git reset --hard --no-show-new-head-line HEAD >actual &&
> > +	! grep "HEAD is now at" <actual
> > +'
> 
> As builtin/reset.c::print_new_head_line() does this:
> 
> 	printf(_("HEAD is now at %s"), hex);
> 
> this needs to use "test_i18ngrep !" instead, no?

Ah yes you're right.  Thanks for catching this.