From: Jeff King <peff@peff.net>
Date: Fri, 30 Mar 2018 20:30:46 GMT
Subject: Re: [PATCH v7 05/13] pack-objects: move in_pack_pos out of struct object_entry
Message-ID: <20180330203045.GD14782@sigill.intra.peff.net>
In-Reply-To: <20180324063353.24722-6-pclouds@gmail.com>

On Sat, Mar 24, 2018 at 07:33:45AM +0100, Nguyễn Thái Ngọc Duy wrote:

> This field is only need for pack-bitmap, which is an optional
> feature. Move it to a separate array that is only allocated when
> pack-bitmap is used (it's not freed in the same way that objects[] is
> not).

I had trouble parsing the parenthetical in the last sentence. It does
make sense if you read it hard enough, but maybe:

  (like objects[], it is not freed, since we need it until the end of
  the process)

would be more clear?

The patch itself seems OK.

-Peff